Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC]: Add C implementation for @stdlib/math/base/special/rempio2 #781

Closed
3 tasks done
Pranavchiku opened this issue Dec 26, 2022 · 10 comments
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/rempio2 #781

Pranavchiku opened this issue Dec 26, 2022 · 10 comments
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 4 Likely to be moderately difficult. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Pranavchiku commented Dec 26, 2022

Description

This RFC proposes adding C implementation for @stdlib/math/base/special/rempio2.

double stdlib_base_rempio2( const double x, double *y );

Related Issues

Related issues #735.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added Enhancement Issue or pull request for enhancing existing functionality. RFC Request for comments. Feature requests and proposed changes. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. labels Dec 26, 2022
@Pranavchiku Pranavchiku self-assigned this Dec 26, 2022
@kgryte
Copy link
Member

kgryte commented Dec 27, 2022

For reference, we could alternatively have the signature be

rempio2( const double x, double *y1, double *y2 );

Where y1 and y2 are pointers for storing output values. However, this is not conventional. Instead, FreeBSD expects a pointer to a two-element array. It is fine for us to do the same.

@Pranavchiku Pranavchiku removed their assignment Jan 17, 2023
@lovelindhoni
Copy link
Contributor

Hello @kgryte @Pranavchiku I would like to work on this issue :)

@Pranavchiku
Copy link
Member Author

@lovelindhoni I'll prefer you to apply review and get #1659 merged.

@Pranavchiku
Copy link
Member Author

Also this PR depends on round.

@USERSATOSHI
Copy link
Contributor

USERSATOSHI commented Mar 17, 2024

@Pranavchiku I think we can start working on this as the pkgs for this are already implemented in C

if it is fine can I take up this issue as I have completed the kernel rempio functions ?

@USERSATOSHI
Copy link
Contributor

USERSATOSHI commented Mar 17, 2024

Also this PR depends on round.

I only saw these pkg being used in rempio2 found it in medium

high-word-abs-mask, high-word-exponent-mask, high-word-significand-mask, get-high-word, get-low-word, from-words

@kgryte kgryte added Accepted RFC feature request which has been accepted. priority: High High priority concern or feature request. difficulty: 4 Likely to be moderately difficult. C Issue involves or relates to C. and removed Native Addons Issue involves or relates to Node.js native add-ons. labels Mar 17, 2024
@xaman27x
Copy link

@USERSATOSHI Since this issue was not assigned specifically, I've been working on this issue and have nearly implemented it,
If possible, could you please let me know if there are any packages required for this?
If you have been working on this too, please let me know!
Best.

@USERSATOSHI
Copy link
Contributor

@USERSATOSHI Since this issue was not assigned specifically, I've been working on this issue and have nearly implemented it, If possible, could you please let me know if there are any packages required for this? If you have been working on this too, please let me know! Best.

@xaman27x this package as of right now was not assigned as this is dependent on @stdlib/math/base/special/round which is right now in opened pull request state as requires review

and on my side , it is on hold until the c implementation of round is merged

@USERSATOSHI
Copy link
Contributor

my bad it seems like the message repeated cause of poor network connection while i doubled clicked on comment as it wasn't sending

@kgryte
Copy link
Member

kgryte commented Jul 27, 2024

This has now been implemented. Closing...

@kgryte kgryte closed this as completed Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 4 Likely to be moderately difficult. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Development

No branches or pull requests

5 participants