Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Debug Password Entry #13

Open
AZielinsky95 opened this issue Dec 8, 2021 · 0 comments
Open

Improve Debug Password Entry #13

AZielinsky95 opened this issue Dec 8, 2021 · 0 comments
Assignees

Comments

@AZielinsky95
Copy link
Contributor

From #12

A lot of times the current interface we actually use for unlocking the debug menu is that the long press / multi-tap gesture doesn't GO to the debug menu, but shows a hidden menu item in the settings view that can now just go directly to the settings view. That's always going to require a little more involvement from the app itself then this approach (need to add a view to the List for your menu or whatever), but it's be nice if it was structured so that you can at least use the password checking logic in that case (Maybe you can pass the debugEntry modifier a custom binding to toggle instead of actually showing the menu, and then put a regular list item that does a drill in to the debug menu, either one we provide or custom to the app, that's shown or hidden based on that binding in your settings view).

It might be nice to have some way to set a global default for the password (so if you have multiple entry points, they can just automatically use the same password).

It would also be nice to have some select-ability in what gesture to use. In particular, I think it could be useful to have two entry points with different complexity of gestures. Like one relatively easy one that's a little hidden (long press on this specific view in the settings menu) and one more global one with a more complicated gesture (three finger quadruple tap on the root view to bring the debug menu up from ANYWHERE). Maybe debugEntry should take an enum of what gesture to use rather than just a long press duration?

Speaking of that, we should try and verify that this modifier CAN be used to put in a global gesture that can be triggered from anywhere (obviously do need an option for a more complicated gesture to make that at all feasible). It seems like it should (just put the modifier on the root view of the scene), but it'd be nice to verify that works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant