Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ResizableImage into two components #36

Open
AZielinsky95 opened this issue Aug 11, 2022 · 0 comments
Open

Split ResizableImage into two components #36

AZielinsky95 opened this issue Aug 11, 2022 · 0 comments

Comments

@AZielinsky95
Copy link
Contributor

Right now ResizableImage handles async and sync images which is great, however, ideally, the async version should allow for a generic placeholder view as well as a generic error view. Adding this functionality to the current component would cause generic constraint errors in any places that define it as a required property. Therefore, it's best we split this component into a synchronous and asynchronous version.

Proposal: NiceImage & AsyncNiceImage to fit with the naming convention of the Nice components in this lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant