Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visibility of $debug_info property #87

Open
Revine-dev opened this issue Nov 13, 2024 · 8 comments
Open

Change visibility of $debug_info property #87

Revine-dev opened this issue Nov 13, 2024 · 8 comments

Comments

@Revine-dev
Copy link

Hello,

Can you please change visibility of the property private $debug_info = array(); to protected please for heritage purpose please ?

Thank you
Rémi

@stefangabos
Copy link
Owner

Yes, I can - and I am working on it right now (I need to update my documentation generator script to highlight visibility)
Can you tell me why do you need this though?

@stefangabos
Copy link
Owner

stefangabos commented Nov 13, 2024

Done, see 371534f.
I am still curios as to how do you plan on using this.
Thanks!

@Revine-dev
Copy link
Author

Revine-dev commented Nov 13, 2024

Perfect !
I forgot to mention that I also need to apply the logic for the connection property and the _is_debugging_enabled() method.

Can you do that please ?

Thanks for this, this is actually to create a child class and get debugging inside Ajax JSON result.

@stefangabos
Copy link
Owner

have you tried using the debug_ajax property? i would love to get some feedback on it and make it more useful

@Revine-dev
Copy link
Author

My debug output is on Json format, so this property does not work how I need

@stefangabos
Copy link
Owner

yeah, i started working on it so that it doesn't tamper the ajax request's output

@Revine-dev
Copy link
Author

If you can please add this property and the method to protected, it'd be great

@stefangabos
Copy link
Owner

I just pushed a proper working way (i think!) for debugging AJAX requests. Read the docs about how to set it up. Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants