Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify for node, to only pop variables off the context stack, that are actually local to it. #197

Open
kaygro opened this issue Feb 11, 2018 · 1 comment

Comments

@kaygro
Copy link

kaygro commented Feb 11, 2018

This would not affect vanilla stencil templates, but would enable modifications inside a for loop, that are visible outside of it (as would be very nice to have for the StencilSwiftKit extension).
I'll try to make a pull request today for these modifications.

Thers' actually a second option of achievingthe same thing by just modifying the Contexts subscript setter to to work more similar to its getter.

I'll make a pull request for that as well.

@kaygro
Copy link
Author

kaygro commented Feb 11, 2018

turns out, the second method is incompatible to several existing testcases(even though they are limited to class Context)....so, theres just one pullrequest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant