From 00618e94eb83d6d82b69aa9ae609aacf5ac7864a Mon Sep 17 00:00:00 2001
From: Phu Le <lehoangphu@gmail.com>
Date: Tue, 11 Sep 2018 15:53:05 -0700
Subject: [PATCH] THREE.VRController.onGamepadDisconnect needs to be called
 when controllers are removed.

The flow of the bug goes like this:
. When the controller is connected, the gamepad object is saved at this.controller[x]
. then when the controller is disconnected, the saved this.controller[x] is still in your array but the object is gone (all null)
. then when the controller is reconnected again, it see that both gamepads[x] and this.controller[x] are both non-null so it does not update, then goes on to consume this.controller[x] which is already stale.

This change makes sure that we flush out the this.controllers array correctly.
---
 VRController.js | 22 ++++++++++++----------
 1 file changed, 12 insertions(+), 10 deletions(-)

diff --git a/VRController.js b/VRController.js
index 0811c71..9ad1c8f 100644
--- a/VRController.js
+++ b/VRController.js
@@ -1,4 +1,4 @@
-/**
+/**
  * @author Stewart Smith / http://stewartsmith.io
  * @author Moar Technologies Corp / https://moar.io
  * @author Jeff Nusz / http://custom-logic.com
@@ -661,7 +661,7 @@ THREE.VRController.verbosity = 0//0.5 or 0.7 are good...
 //  and have some connection / disconnection handlers.
 
 THREE.VRController.controllers = []
-THREE.VRController.onGamepadConnect = function( gamepad ){
+THREE.VRController.onGamepadConnect = function( gamepad, index ){
 
 
 	//  Let’s create a new controller object
@@ -675,10 +675,10 @@ THREE.VRController.onGamepadConnect = function( gamepad ){
 
 
 	//  We also need to store this reference somewhere so that we have a list
-	//  controllers that we know need updating, and by using the gamepad.index
+	//  controllers that we know need updating, and by using the index
 	//  as the key we also know which gamepads have already been found.
 
-	scope.controllers[ gamepad.index ] = controller
+	scope.controllers[ index ] = controller
 
 
 	//  Now we’ll broadcast a global connection event.
@@ -695,7 +695,7 @@ THREE.VRController.onGamepadConnect = function( gamepad ){
 
 	}, 500 )
 }
-THREE.VRController.onGamepadDisconnect = function( gamepad ){
+THREE.VRController.onGamepadDisconnect = function( index ){
 
 
 	//  We need to find the controller that holds the reference to this gamepad.
@@ -707,11 +707,11 @@ THREE.VRController.onGamepadDisconnect = function( gamepad ){
 
 	var
 	scope = THREE.VRController,
-	controller = scope.controllers[ gamepad.index ]
+	controller = scope.controllers[ index ]
 
 	if( scope.verbosity >= 0.5 ) console.log( 'vr controller disconnected', controller )
 	controller.dispatchEvent({ type: 'disconnected', controller: controller })
-	scope.controllers[ gamepad.index ] = undefined
+	scope.controllers[ index ] = undefined
 }
 
 
@@ -780,7 +780,7 @@ THREE.VRController.update = function(){
 
 			if( gamepad.pose.orientation !== null || gamepad.pose.position !== null ){
 
-				if( this.controllers[ i ] === undefined ) THREE.VRController.onGamepadConnect( gamepad )
+				if( this.controllers[ i ] === undefined ) THREE.VRController.onGamepadConnect( gamepad, i )
 				this.controllers[ i ].update()
 			}
 
@@ -791,8 +791,10 @@ THREE.VRController.update = function(){
 			//  the controller! (At least in Chromium.) That doesn’t seem like
 			//  the API’s intended behavior but it’s what I see in practice.
 
-			else if( this.controllers[ i ] !== undefined ) THREE.VRController.onGamepadDisconnect( gamepad )
+			else if( this.controllers[ i ] !== undefined ) THREE.VRController.onGamepadDisconnect( i )
 		}
+                // If the controller is disconnected and remove then we should update this.controllers accordingly 
+		else if( this.controllers[ i ] !== undefined ) THREE.VRController.onGamepadDisconnect( i );
 	}
 }
 THREE.VRController.inspect = function(){
@@ -1473,4 +1475,4 @@ OrientationArmModel.prototype.quatAngle_ = function( q1, q2 ){
 	vec1.applyQuaternion( q1 );
 	vec2.applyQuaternion( q2 );
 	return vec1.angleTo( vec2 );
-}
\ No newline at end of file
+}