Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main executor for WASM doesn't seems to be fully implemented #373

Open
keminming opened this issue Mar 16, 2021 · 1 comment
Open

Main executor for WASM doesn't seems to be fully implemented #373

keminming opened this issue Mar 16, 2021 · 1 comment
Labels

Comments

@keminming
Copy link

keminming commented Mar 16, 2021

By looking at
Main_executor.hpp, for Emscripten case, if seems falls back to use default_executor. To my knowledge jobs will be run in secondary threads in default_executor. So need main executor guarantee the job will be scheduled to the main thread sharing the semantic for other platform.

#elif STLAB_MAIN_EXECUTOR == STLAB_MAIN_EXECUTOR_EMSCRIPTEN
using main_executor_type = default_executor_type;

Also. #elif STLAB_MAIN_EXECUTOR == STLAB_MAIN_EXECUTOR_PORTABLE
#if APPLE not define, the implementation is not complete

@keminming keminming changed the title Main executor on WASM doesn't seems to be fully implemented Main executor for WASM doesn't seems to be fully implemented Mar 19, 2021
@dabrahams
Copy link
Contributor

Contributions welcome.

@dabrahams dabrahams added the bug label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants