Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Storeman sometimes crashes when submitting a comment #83

Open
Olf0 opened this issue Jan 15, 2019 · 3 comments
Open

[Bug] Storeman sometimes crashes when submitting a comment #83

Olf0 opened this issue Jan 15, 2019 · 3 comments
Labels
bug This is indeed a bug

Comments

@Olf0
Copy link
Member

Olf0 commented Jan 15, 2019

Storeman sometimes crashes when submitting a comment, after editing it or writing a new one.
This also has been reported at OpenRepos [1] and [2] recently.
But the new / altered comment is always successfully sent before the crash. :)

I think this issue is new in Storeman 0.0.32 (not sure though, as there have been many Storeman releases in November: 0.0.29, 0.0.30, 0.0.31 and 0.0.32), before new or altered comments sometimes did "not get through", but OTOH earlier versions of Storeman did not crash then.

Unfortunately this issue seems to evade reproducibility: It always works when trying to reproduce it, but occurs about every third to fifth time I am using the comment function for real.

I have the feeling (but not more than that), that this is still related to the Storeman user having lost authorisation to submit comments at OpenRepos (it seems to be tricky to detect that) while trying to submit a comment. Maybe I should be more patient and wait a long time when trying to reproduce this.
Edit: Obviously one is still authorised to post at OpenRepos, as the comments are successfully submitted.

Nevertheless IMHO Storeman should not crash in this situation, although it is rather an annoyance than a serious bug (as comments were always successfully submitted when Storeman 0.0.32 crashes).

@mentaljam
Copy link
Collaborator

I also confirm this issue. The trouble is that to find the cause of the crash one should catch it with debugger (launch Storeman with the SDK and continue commenting until it will crash).

@mentaljam mentaljam added the bug This is indeed a bug label Jan 16, 2019
mentaljam added a commit that referenced this issue Feb 4, 2019
@Olf0 Olf0 mentioned this issue Sep 27, 2019
mentaljam added a commit that referenced this issue Jun 29, 2020
@Olf0
Copy link
Member Author

Olf0 commented Sep 1, 2020

BTW, this seems to have become a bit better (i.e., less crashes and the comment is always sucessfully posted), but still happens: Twice yesterday with Storeman 0.18.

@Olf0
Copy link
Member Author

Olf0 commented Mar 17, 2022

I have not observed this any more, but almost stopped using Storeman for commenting at OpenRepos. I am inclined to close this.

If somebody reads this, because this bug still occurs, please speak up (i.e., leave a comment here, with the usual informations needed: Storeman version, SailfishOS version, device used etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is indeed a bug
Projects
None yet
Development

No branches or pull requests

2 participants