Missing types for fetching links query params

[bevanmw]

---

Current Behavior

You can fetch the links via this API (https://www.storyblok.com/docs/api/content-delivery/v2/links/retrieve-multiple-links) by using the js client:

const { data } = await storyblokApi?.get(`cdn/links`, {
  version: 'draft',
  include_dates: 1
});

However the get method expects the second param to be of type ISbStoriesParams which is not the same as the query params that are accepted by the API: https://www.storyblok.com/docs/api/content-delivery/v2/links/retrieve-multiple-links.

Also, the type ISbLink does not include the published_at, created_at and updated_at fields that are included when include_dates is set to 1.

Expected Behavior

I propose that there should be a dedicated getLinks method like there is for getStories. Which takes in the correct query params for fetching links.

Steps to Reproduce

1. Try to add include_dates parameter to get method which fetching cdn/links
2. Typescript error despite the query parameter working as documented here: https://www.storyblok.com/docs/api/content-delivery/v2/links/retrieve-multiple-links
3. updated_at field not present on ISbLink:
   
   

[edodusi]

@bevanmw I would not add a dedicated endpoint for links, as an overload should be enough. I fixed the type errors in this PR #911 if you want to check it out, we will review and merge it soon.

Thanks for reporting the error!

[bevanmw]

Thanks @edodusi ! Yes, an overload is much better solution. I checked out your fix and it works really well.

[edodusi]

Thanks @bevanmw, it will go through our review process and we'll release it soon, also with updates to our SDKs

[github-actions]

🎉 This issue has been resolved in version 6.10.6 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀