From d446ab9366268fbec090c65b282d230310ec2b6b Mon Sep 17 00:00:00 2001 From: B Hamilton Date: Mon, 28 Feb 2022 11:51:55 +0000 Subject: [PATCH 1/2] create proposal document --- ...-allow-relations-to-be-repeatable-title.md | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 rfcs/xxxx-allow-relations-to-be-repeatable-title.md diff --git a/rfcs/xxxx-allow-relations-to-be-repeatable-title.md b/rfcs/xxxx-allow-relations-to-be-repeatable-title.md new file mode 100644 index 0000000..a6cec8f --- /dev/null +++ b/rfcs/xxxx-allow-relations-to-be-repeatable-title.md @@ -0,0 +1,40 @@ +- Start Date: (fill in today's date, YYYY-MM-DD) +- RFC PR: (leave this empty) + +# Summary + +Allow repeatable components to use a relation as their title, screenshots of change in rejected PR here: https://github.com/strapi/strapi/pull/12650 + + +# Example + +If the proposal requires changes to the current API or the creation of new ones, add a basic code example. + +# Motivation + +To allow the UI to be intuitive when creating repeatables with only relation properties (only way to create ordered array of relations) + +# Detailed design + +Describe the proposal in details: + +screenshots of change in rejected PR here: https://github.com/strapi/strapi/pull/12650 + +# Tradeoffs + +What potential tradeoffs are involved with this proposal. + +- Complexity +- Work load of implementation +- Can this be implemented outside of Strapi's core packages +- How does this proposal integrate with the current features being implemented +- Cost of migrating existing Strapi applications (is it a breaking change?) +- Does implementing this proposal mean reworking teaching resources (videos, tutorials, documentations)? + +# Alternatives + +Create option of relation array + +# Unresolved questions + +Optional, but suggested for first draft proposals. What parts of the design are still TBD(To be defined)? From 8673f7426175ee2a83367c46dc89c1f417fac4e2 Mon Sep 17 00:00:00 2001 From: B Hamilton Date: Mon, 28 Feb 2022 15:15:35 +0000 Subject: [PATCH 2/2] update details --- rfcs/xxxx-allow-relations-to-be-repeatable-title.md | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/rfcs/xxxx-allow-relations-to-be-repeatable-title.md b/rfcs/xxxx-allow-relations-to-be-repeatable-title.md index a6cec8f..67ec0ab 100644 --- a/rfcs/xxxx-allow-relations-to-be-repeatable-title.md +++ b/rfcs/xxxx-allow-relations-to-be-repeatable-title.md @@ -1,5 +1,5 @@ -- Start Date: (fill in today's date, YYYY-MM-DD) -- RFC PR: (leave this empty) +- Start Date: 2022-02-28 +- RFC PR: # Summary @@ -8,7 +8,13 @@ Allow repeatable components to use a relation as their title, screenshots of cha # Example -If the proposal requires changes to the current API or the creation of new ones, add a basic code example. +https://github.com/strapi/strapi/compare/master...hamilton-b:bug/relations-not-showing-title?expand=1 + +Before - see blank title on repeatable: +before + +With change, it will now use the title of the relation +after # Motivation