Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we make gen_default_table methods public? #840

Closed
jbaublitz opened this issue Mar 9, 2023 · 1 comment
Closed

Should we make gen_default_table methods public? #840

jbaublitz opened this issue Mar 9, 2023 · 1 comment
Assignees

Comments

@jbaublitz
Copy link
Member

jbaublitz commented Mar 9, 2023

Related to #839 and stratis-storage/stratisd#3274

It's unclear to me whether they're of much use to people outside of this group. If they are, I'd say we should. If they aren't, I'm happy to reimplement the logic where I need to.

@jbaublitz jbaublitz self-assigned this Mar 9, 2023
@mulkieran
Copy link
Member

I don't think we should. I think they were a hack to begin with, and very stratisd specific. What should have happened is that it should have been possible to pass the TargetParams or maybe better the whole TargetTable to the new() methods, and clients of the library could pass whatever was useful to them. We even have an issue about this[1], but we have never had the time to address it.

[1] #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants