Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary useEffect and ref in usePrevious hook #2617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unnecessary useEffect and ref in usePrevious hook #2617

wants to merge 1 commit into from

Conversation

RickHuizing01
Copy link

Description

This merge request resolves GitHub Issue #2605 by updating the usePrevious hook to adhere to React's best practices. For a detailed explanation of the proposed implementation, please refer to the issue and its comments.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove potentially unnecessary use of useEffect in usePrevious
1 participant
@RickHuizing01