Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion of improvement when embedding content for better user experience #25

Open
moodlemobile opened this issue Oct 8, 2024 · 1 comment

Comments

@moodlemobile
Copy link

In order to provide a better experience to users when embedding content from the site (for example, a Moodle site page with a code to embed a video) we recommend using our component "core-iframe" instead of just iframe as it will automatically log in the user into the site (Android and iOS)

Our suggestion will be to update this line:
https://github.com/streamingltd/MEDIAL-Moodle-Activity/blob/603f7c1374cefa3826c26e943f5ac0de85f07af7/templates/mobile_view_page.mustache#L5

With something similar to was used here:
https://github.com/mattan-d/moodle-mod_stream/blob/master/templates/mobile_view_page.mustache#L39

@tim1mw
Copy link
Contributor

tim1mw commented Nov 6, 2024

This seems like a useful change, which I've just tried on our test system. I'm guessing that there are some css diffferences in Moodle mobile that affects how core-iframe adapts to the screen size, since it caused the frame to constantly jump back and forth between two sizes making the video unuseable. (See attached video).

adaptation-problem.mp4

I experiencend the same problem on two different Android devices with the latest MoodleMobile. Reverting to a regular Iframe fixed the problem.

I tried taking out all the attributes from core-iframe leaving just:

<core-iframe src="{{launchurl}}" ></core-iframe>

In case the height or style that is there was causing the issue, but it made no difference, the resizing just continued in a loop.

It may be there is something in the MEDIAL code within the Iframe I can do to mitigate this, but any thoughts on the cause here would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants