From 11e8833fb3ab6cefa60d18e535e12f4ad7112055 Mon Sep 17 00:00:00 2001
From: Songlin Yang <lsytj0413@gmail.com>
Date: Tue, 21 Jan 2025 16:45:03 +0800
Subject: [PATCH] test(572): fix flaky test with TestSecondaryIndices_List
 (#595)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Before fix，when run with `go test -timeout 10m -run
^TestSecondaryIndices_List$ github.com/streamnative/oxia/server -gcflags
all='-N' -v -count=10000`, the flaky test reproduced.

After fix, run multi times tests without fail.

fix: https://github.com/streamnative/oxia/issues/582
---
 server/secondary_indexes_test.go | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/server/secondary_indexes_test.go b/server/secondary_indexes_test.go
index b25abd6f..cce5fb74 100644
--- a/server/secondary_indexes_test.go
+++ b/server/secondary_indexes_test.go
@@ -65,7 +65,10 @@ func TestSecondaryIndices_List(t *testing.T) {
 	assert.Equal(t, "/b", k)
 	k = <-strCh
 	assert.Equal(t, "/c", k)
-	assert.Empty(t, strCh)
+	// NOTE: we cannot use assert.Empty to check strCh and must to validate it's closed, because when there is no more
+	// items to return, assert.Empty will passthrough and leave the iterator opened.
+	_, ok := <-strCh
+	assert.False(t, ok)
 
 	// Wrong index
 	strCh, err = lc.List(context.Background(), &proto.ListRequest{
@@ -75,7 +78,8 @@ func TestSecondaryIndices_List(t *testing.T) {
 		SecondaryIndexName: pb.String("wrong-idx"),
 	})
 	assert.NoError(t, err)
-	assert.Empty(t, strCh)
+	_, ok = <-strCh
+	assert.False(t, ok)
 
 	// Individual delete
 	_, err = lc.Write(context.Background(), &proto.WriteRequest{
@@ -99,8 +103,8 @@ func TestSecondaryIndices_List(t *testing.T) {
 	assert.Equal(t, "/d", k)
 	k = <-strCh
 	assert.Equal(t, "/e", k)
-
-	assert.Empty(t, strCh)
+	_, ok = <-strCh
+	assert.False(t, ok)
 
 	// Range delete
 	_, err = lc.Write(context.Background(), &proto.WriteRequest{
@@ -124,7 +128,8 @@ func TestSecondaryIndices_List(t *testing.T) {
 	assert.Equal(t, "/d", k)
 	k = <-strCh
 	assert.Equal(t, "/e", k)
-	assert.Empty(t, strCh)
+	_, ok = <-strCh
+	assert.False(t, ok)
 
 	assert.NoError(t, lc.Close())
 	assert.NoError(t, kvFactory.Close())