Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement blob verification #5

Closed
zobront opened this issue Jul 9, 2024 · 3 comments
Closed

Implement blob verification #5

zobront opened this issue Jul 9, 2024 · 3 comments
Assignees

Comments

@zobront
Copy link
Collaborator

zobront commented Jul 9, 2024

Blob verification needs to be implemented in the zkVM.

opening(field_element_key[..48] at field_element_key[72..]) = field_element
@zobront zobront self-assigned this Jul 9, 2024
@zobront
Copy link
Collaborator Author

zobront commented Jul 9, 2024

Status Update: Implemented in the oracle's verify() function.

This is blocked because it requires the ability to customize the fetcher to store the kzg proof, since that isn't included in Kona's default host implementation. This would be 2 lines to add to the current Kona host, but may be more work to help upstream changes to allow custom fetcher modifications without forking the host.

@zobront
Copy link
Collaborator Author

zobront commented Jul 11, 2024

Confirmed with Clabby that he's comfortable with workaround of saving the KZG proof in their fetcher implementation until they implement the above.

Upstream PR to do this is here: op-rs/kona#370

We still need kzg-rs to implement the verify_blob_kzg_proof() function to finalize this and ensure it works.

@puma314 puma314 assigned ratankaliani and unassigned zobront Jul 15, 2024
@zobront
Copy link
Collaborator Author

zobront commented Jul 16, 2024

@ratankaliani FYI: Upstream PR is merged so all that's left on this is getting the verify_blob_kzg_proof() function implemented in kzg-rs so that this can be uncommented: https://github.com/moongate-forks/kona-sp1/blob/8e84327d513e644a19c35038113a58609e0eb9fd/zkvm-client/src/oracle/mod.rs#L145-L146

See: https://succinctlabs.slack.com/archives/C075AD6FYH4/p1720755576381199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants