diff --git a/lib/mods_display/fields/cartographics.rb b/lib/mods_display/fields/cartographics.rb index 36da882..225e7df 100644 --- a/lib/mods_display/fields/cartographics.rb +++ b/lib/mods_display/fields/cartographics.rb @@ -10,7 +10,7 @@ def fields next unless subject_element.respond_to?(:cartographics) subject_element.cartographics.each do |field| - scale = field.scale.empty? ? 'Scale not given' : element_text(field.scale) + scale = field.scale.empty? ? nil : element_text(field.scale) projection = field.projection.empty? ? nil : element_text(field.projection) coordinates = field.coordinates.empty? ? nil : element_text(field.coordinates) post_scale = [projection, coordinates].compact.join(' ') if [projection, coordinates].compact.length.positive? diff --git a/spec/fields/cartographics_spec.rb b/spec/fields/cartographics_spec.rb index 40cca30..f5d8a12 100644 --- a/spec/fields/cartographics_spec.rb +++ b/spec/fields/cartographics_spec.rb @@ -25,7 +25,7 @@ def mods_display_cartographics(mods) it 'puts a scale not given note if no scale is present' do values = mods_display_cartographics(@no_scale).fields expect(values.length).to eq(1) - expect(values.first.values).to eq(['Scale not given ; the projection the coordinates']) + expect(values.first.values).to eq(['the projection the coordinates']) end it 'handles when there is only a scale note' do @@ -37,7 +37,7 @@ def mods_display_cartographics(mods) it 'handles when only one post-scale piece of the data is available' do values = mods_display_cartographics(@coordinates).fields expect(values.length).to eq(1) - expect(values.first.values).to eq(['Scale not given ; the coordinates']) + expect(values.first.values).to eq(['the coordinates']) end end end diff --git a/spec/helpers/record_helper_spec.rb b/spec/helpers/record_helper_spec.rb index 82d6b87..21611b7 100644 --- a/spec/helpers/record_helper_spec.rb +++ b/spec/helpers/record_helper_spec.rb @@ -5,7 +5,7 @@ describe 'mods_display_label' do it 'returns correct label' do - expect(helper.mods_display_label('test:')).not_to have_content ':' + expect(helper.mods_display_label('test:')).to have_no_content ':' expect(helper.mods_display_label('test:')).to have_css('dt', text: 'test') end end