From 74e91be72ffa9ac667b9d98437d220ec38f75f4a Mon Sep 17 00:00:00 2001
From: tarentomaheshvakkund
 <139739142+tarentomaheshvakkund@users.noreply.github.com>
Date: Fri, 21 Jun 2024 20:54:34 +0530
Subject: [PATCH] KB-5130 | DEV| Assessment | BE | Enhancement in Consumption
 Logic for the QuestionWeightage Assessment Type (#621)

1. Accuracy calculation is same for final assessment and practice assessment.
---
 .../assessment/service/AssessmentServiceV5Impl.java   | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/main/java/org/sunbird/assessment/service/AssessmentServiceV5Impl.java b/src/main/java/org/sunbird/assessment/service/AssessmentServiceV5Impl.java
index 336ba9ddb..167d8eef0 100644
--- a/src/main/java/org/sunbird/assessment/service/AssessmentServiceV5Impl.java
+++ b/src/main/java/org/sunbird/assessment/service/AssessmentServiceV5Impl.java
@@ -392,13 +392,12 @@ public SBApiResponse submitAssessmentAsync(Map<String, Object> submitRequest, St
                     }
                 }
                 if (Constants.SECTION_LEVEL_SCORE_CUTOFF.equalsIgnoreCase(scoreCutOffType)) {
-                    boolean practiceAssessmentFlag = ((String) assessmentHierarchy.get(Constants.PRIMARY_CATEGORY)).equalsIgnoreCase(Constants.PRACTICE_QUESTION_SET);
                     long assessmentStartTime = 0;
                     if (existingAssessmentData.get(Constants.START_TIME)!=null) {
                         Date assessmentStart = (Date) existingAssessmentData.get(Constants.START_TIME);
                         assessmentStartTime = assessmentStart.getTime();
                     }
-                    Map<String, Object> result = calculateSectionFinalResults(sectionLevelsResults,assessmentStartTime,assessmentCompletionTime,maxAssessmentRetakeAttempts,retakeAttemptsConsumed,practiceAssessmentFlag);
+                    Map<String, Object> result = calculateSectionFinalResults(sectionLevelsResults,assessmentStartTime,assessmentCompletionTime,maxAssessmentRetakeAttempts,retakeAttemptsConsumed);
                     outgoingResponse.getResult().putAll(result);
                     outgoingResponse.getParams().setStatus(Constants.SUCCESS);
                     outgoingResponse.setResponseCode(HttpStatus.OK);
@@ -790,7 +789,7 @@ private void writeDataToDatabaseAndTriggerKafkaEvent(Map<String, Object> submitR
         }
     }
 
-    private Map<String, Object> calculateSectionFinalResults(List<Map<String, Object>> sectionLevelResults, long assessmentStartTime, long assessmentCompletionTime, int maxAssessmentRetakeAttempts, int retakeAttemptsConsumed, boolean practiceAssessmentFlag) {
+    private Map<String, Object> calculateSectionFinalResults(List<Map<String, Object>> sectionLevelResults, long assessmentStartTime, long assessmentCompletionTime, int maxAssessmentRetakeAttempts, int retakeAttemptsConsumed) {
         Map<String, Object> res = new HashMap<>();
         Double result;
         Integer correct = 0;
@@ -820,11 +819,7 @@ private Map<String, Object> calculateSectionFinalResults(List<Map<String, Object
                     totalMarks += (Integer) sectionChildren.get(Constants.TOTAL_MARKS);
                 }
             }
-            if(practiceAssessmentFlag){
-                res.put(Constants.OVERALL_RESULT, ((double)correct / (double)(blank+correct+inCorrect)) * 100);
-            }else{
-                res.put(Constants.OVERALL_RESULT, totalResult / sectionLevelResults.size());
-            }
+            res.put(Constants.OVERALL_RESULT, ((double)correct / (double)(blank+correct+inCorrect)) * 100);
             res.put(Constants.BLANK, blank);
             res.put(Constants.CORRECT, correct);
             res.put(Constants.INCORRECT, inCorrect);