Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand testing #82

Open
dswigh opened this issue Apr 25, 2023 · 0 comments
Open

Expand testing #82

dswigh opened this issue Apr 25, 2023 · 0 comments

Comments

@dswigh
Copy link
Collaborator

dswigh commented Apr 25, 2023

  1. find a case for test_rxn_input_extractor and handle_rxn_obj that contains ice
  2. Check that solvents csv is well formed
  3. Test all 4 options for handling unresolvable names (TFF, FTF, FFT, FFF): set_unresolved_names_to_none_if_mapped_rxn_str_exists_else_del_rxn, remove_rxn_with_unresolved_names, set_unresolved_names_to_none
  4. is_mapped function in cleaning
  5. Check that there are no solvents outside solvents label, unless it has a mapped atom (and is thus a reactant).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dswigh