Skip to content
This repository has been archived by the owner on Oct 13, 2022. It is now read-only.

should emit css be false for server in rollup template? #190

Open
vipero07 opened this issue Jan 3, 2020 · 1 comment
Open

should emit css be false for server in rollup template? #190

vipero07 opened this issue Jan 3, 2020 · 1 comment

Comments

@vipero07
Copy link

vipero07 commented Jan 3, 2020

The webpack template sets css to false on the server version.

This is different from the rollup version which doesn't set emitCss to false.

The opposite holds true for the client versions. I'm not sure what the defaults are and if they differ between the webpack and rollup implementations, but it feels wrong if that's the case. Furthermore if I understand correctly, setting emitCss to false would inline the styles, which would be better for Lighthouse benchmarks.

vipero07 added a commit to vipero07/sapper-template that referenced this issue Jan 3, 2020
@vipero07
Copy link
Author

vipero07 commented Jan 3, 2020

Made a patch you can pull in if you want.
https://github.com/vipero07/sapper-template/tree/patch-1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant