Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimise changes to the TNLS-Gateway #52

Open
ltfschoen opened this issue Jan 2, 2025 · 0 comments
Open

Minimise changes to the TNLS-Gateway #52

ltfschoen opened this issue Jan 2, 2025 · 0 comments

Comments

@ltfschoen
Copy link
Collaborator

The public key of the user that deploys the custom Nunya.Business contract is sent through to the custom EVM Gateway contract so only that user may call that custom EVM Gateway contract, however we actually want to try and use the default EVM Gateway contract that has been deployed by the Secret network team with minimal changes and move the logic to the Secret contract instead. Apart from the creator of the Nunya.Business contract, the only other users that call any Secret network functions are accounts whose public keys are provided by the creator of the Nunya.Business giving those accounts permission to call the withdraw function.

Also consider using the TNLS-Gateway from https://github.com/ltfschoen/SecretPath/blob/main/TNLS-Gateways/public-gateway/src/Gateway.sol since that template is in the same repo as the Relayer that we're using via Git Submodules, and migrate our changes across to that, although it might be necessary to use symlinks for deployment and unnecessary complexity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant