Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to size! #1

Open
0xhunster opened this issue Apr 11, 2023 · 9 comments
Open

add option to size! #1

0xhunster opened this issue Apr 11, 2023 · 9 comments

Comments

@0xhunster
Copy link

I hope you are doing well! could you update the script to add a new option like screenshot size?

@swanandx
Copy link
Owner

Hey, Added option to specify size, can you verify it by building from source? currently I added -h/--height and -w/--width. what do u think just -s/--size width,height be a better option?

PS: Thnx for opening this issue, I thought no one was using it so kinda stopped working on it haha

@0xhunster
Copy link
Author

hahaha I thought many people using this script. chill brother. I am searching for a rust-based screenshot script. because gowitness is a very noisy output. Always I like to have minimal output script. finally, I got it from Twitter, but mistakenly I lost your script, then I search more and more, finally got it. and I saw good output showing. without any extra text or error. like it 👍🏻.

I said size, sorry for that. size means height/width. I am using it regularlly 🥰 but one thing I saw screenshot quality not well :(. I will let you know your option work or not.

Thanks brother ♥♥♥

@swanandx
Copy link
Owner

Thank you, it feels so good to know that someone likes what you are building <3 Let me know once you try it, then I will release it ASAP.

btw, wdym by screenshot quality? is it taking screenshot before whole site is loaded or do you mean about resolution? If its later part, I think it will be taken care of when you specify height/width? gowitness uses chromedp and I couldn't find any good alternative for it in rust, headless_chrome works but it isn't async, so currently i'm using chromiumoxide. So yeah, some thing might not be that great yet.

Please feel free to open issues if you are facing some other difficulties!

@0xhunster
Copy link
Author

error showing.

image

@swanandx
Copy link
Owner

I will take a look! it is related to chromiumoxide ig

@0xhunster
Copy link
Author

Any update? Did you fix this issue?

@swanandx
Copy link
Owner

No updates yet 😕

@swanandx
Copy link
Owner

@0xhunster I did try on my machine ( even with brave browser ), it seemed to work just fine! can u just confirm once u are using latest code from main brance?

@0xhunster
Copy link
Author

sorry for the late response. Brother, you can push the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants