-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contents of Global Variables and Logs not showing - Burp Pro 2024.11.1 #79
Comments
Hi @0xquad |
Hi @ddwightx, I can confirm that:
Of note: I had to purge settings from 2024.11.1 installation before extension started working as expected:
|
Hi @tomdottom. Thanks for the info. |
Interesting info, thanks! Tried to reinstall the extension but the behavior is the same for me. Not sure where exactly the preferences are located on Windows though. Looked into |
@0xquad The extension preferences are in Registry at FYI, the key names you see would look like this. If you wanted to selectively delete, here's what everything is: |
Thanks for the info, perfect! So I shut Burp down and backed up the I've created a new simple http rule to capture the user agent header: match on any request from the Repeater tool and set a global variable However I observe the same behavior: the Global Variables tab cannot show the variable contents and the Logs tab is empty. I'll mention also that logs appear in the Extensions Output logs only when 'Replicate Logs to Extension Output' is set in Reshaper Settings (as expected, but didn't notice the first time). If there's anything else I can test let me know! |
Tested once more by removing the burp registry key completely and starting anew and I can confirm what @tomdottom said: the extension works as expected again! 👍 So there must be something that Burp stores in its settings that interferes with Reshaper after version 2024.11. So either users will have to completely reset their Burp settings (not ideal, including considering the license registration), or the fix should come from Reshaper or PortSwigger somehow. I wonder if I could pinpoint exactly what registry key/value causes this but that would take time. Not sure if we want to close this issue or not; the bug does exist, but the cause/fix isn't clear at all although there is this radical workaround. (Info for anyone who wants to preserve their Pro license, the reg keys to keep are the following: |
@0xquad Nice find. I'll contact PortSwigger support about this issue. Let's keep this issue open for now. Thanks! |
OK sorry for the additional noise; I was too annoyed by this and proceeded to test a little more. 😅 Found the culprit: the extension JWT Editor. If you have both loaded at the same time, Reshaper trips and can't display the global variables nor logs. So the workaround for now comes down to: use either extension but not both at the same time. I've tested with my previous fully configured Burp so it seems like this is the only cause and nothing else. The root cause however is not clear (why would they interfere?). In my extension list, Reshaper was after JWT Editor. For further testing: if you have Reshaper loaded and then load JWT Editor, you'll see the Reshaper main navigation bar tab disappear. But it's actually there and you can click on it, which is weird. Restarting Burp in between the tests you can observe different behaviors. Varying the order of the extensions too and then loading/unloading them, or move them up or down the list while loaded. Seems like the extension repo has diverged from how PortSwigger maintains it, so I'm not sure where to go from here. |
@0xquad Excellent debugging! I'm able to reproduce that issue with JWT Editor as well. @tomdottom Can you confirm whether or not you use JWT Editor as well? |
I've done further testing. The issue appears to be between extensions that use the WebSocketMessageEditor based on my testing of extensions I see using it according to https://github.com/search?q=org%3APortSwigger+WebSocketMessageEditor&type=code. Extensions that use UserInterface::createWebSocketMessageEditor (i.e. Socket Sleuth, Reshaper, Websocket Turbo Intruder) do not conflict with each other. However, the extensions that use UserInterface::registerWebSocketMessageEditorProvider (i.e. HaE and JWT Editor) either break themselves or break the extensions that use UserInterface::createWebSocketMessageEditor when the extensions are activated at the same time. The result of the conflict is tabs not loading or tab names disappearing. |
@ddwightx I do indeed us JWT Editor and can confirm that disabling appears to resolve issues viewing variables and logs. Nice work @0xquad 👏 |
Hi! First, thank you so much for this extension; super useful in all kinds of scenarios.
Haven't used it in a while and now, after a few Burp version upgrades, it seems like the Global Variables and Logs tabs do not show any contents. Using the latest version of the extension though.
However it seems like everything still works: variables are created/assigned correctly (and can be used) and I've found that logs are actually shown in the Extensions logs instead. So it seems to be an issue on how the info is displayed within the extension tool itself.
But that does hinder a bit how we can use the extension since we can't view and manipulate global variables. I tried deactivating pretty much all other extensions to make sure it wasn't causing interference.
The text was updated successfully, but these errors were encountered: