Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Weather Widget Feed is missing sun image #2449

Closed
catch-21 opened this issue Jan 30, 2025 · 1 comment
Closed

[Bug]: Weather Widget Feed is missing sun image #2449

catch-21 opened this issue Jan 30, 2025 · 1 comment
Labels
bug Something isn't working triage This issue needs to be looked over by the team

Comments

@catch-21
Copy link
Contributor

catch-21 commented Jan 30, 2025

Describe the bug

The design shows sun image next to 'Favorable Conditions' text.

Reproduce

  1. Go to view Bitcoin Calculator widget on home page
  2. Input some bitcoin value
  3. Observe the fiat conversion value
  4. Go to General Settings and change your local currency
  5. Go back to home page and observe fiat value is unchanged, and likely incorrect.

Screenshots / Recording

Design:
Image

Actual:
Image

Operating system

Android 14

Bitkit version

v1.0.9 (145)

Log output

@catch-21 catch-21 added bug Something isn't working triage This issue needs to be looked over by the team labels Jan 30, 2025
@pwltr
Copy link
Collaborator

pwltr commented Feb 5, 2025

There is an issue on iOS with line-height and rendering large emojis like this, so I'd opt to leave this as is. This also makes the code more reusable for other widgets. I think from a design perspective this is acceptable.

@pwltr pwltr closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage This issue needs to be looked over by the team
Projects
None yet
Development

No branches or pull requests

2 participants