Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social icons in view in browser #38

Open
pbatroff opened this issue Nov 25, 2019 · 5 comments
Open

Social icons in view in browser #38

pbatroff opened this issue Nov 25, 2019 · 5 comments

Comments

@pbatroff
Copy link
Contributor

Social Icons in the versafix template use relative paths, thus the replacement on the proxy to view the mailing doesn't work. Example URL:

/sites/default/files/civicrm/persist/mosaico_tpl/versafix-1.1/img/icons/fb-colors-96.png

This then wont be replaced in the proxy civiproxy_mend_URLs, then having an invalid URL. An additional regex fix should fix the problem for the $target_file replacement.

@pbatroff
Copy link
Contributor Author

Alternatively a page hook could be used in the civiproxy extension on civi side to change the links.

@pbatroff
Copy link
Contributor Author

I created an issue with the mosaico extension here, ideally this should be fixed in there.

@jaapjansma
Copy link
Contributor

I have difficulties with replacing social media icons from the versafix template. The instance is CiviCRM 5.30.1 on Wordpress and Mosaico 2.5.1597918155

I see that the templates have an absolute url.

jaapjansma added a commit to jaapjansma/CiviProxy that referenced this issue Sep 30, 2021
jaapjansma added a commit to jaapjansma/CiviProxy that referenced this issue Nov 19, 2021
jaapjansma added a commit to jaapjansma/CiviProxy that referenced this issue Nov 19, 2021
bjendres added a commit that referenced this issue Nov 19, 2021
@bjendres
Copy link
Member

bjendres commented Sep 5, 2024

@pbatroff is this currently working?

@pbatroff
Copy link
Contributor Author

pbatroff commented Sep 6, 2024

Yes, it is both working with the normal packed icons as well as with Icons in custom themes, as long as the theme folder is located somwhere in [civicrm_files]/persist/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants