Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on interaction of presentation and service layer #6

Open
ruiconti opened this issue Mar 19, 2021 · 0 comments
Open

Improvements on interaction of presentation and service layer #6

ruiconti opened this issue Mar 19, 2021 · 0 comments
Assignees
Labels
design change A change that involves a change of current software design. Orthogonal to a refactor help wanted Extra attention is needed
Milestone

Comments

@ruiconti
Copy link
Contributor

Issue

As of now, in Authentication aggregate, presentation layer (HTTP) sees right through service layer implementations and is responsible for passing proper dependencies, which is not optimal behavior as it is doing more than one thing. It should focus on presenting.

Although is worth checking #5 for a suggestion on improving error handlings.

Proposed solution

Authentication aggregate does not need to chain events, so we suggest and implementation of an Interactor pattern instead of other modules' MessageBus. It'd be responsible for being the unique entrypoint to service layer. In that sense, it is responsible for injecting dependencies downward.

@ruiconti ruiconti added the design change A change that involves a change of current software design. Orthogonal to a refactor label Mar 19, 2021
@ruiconti ruiconti added this to the Going Public milestone Mar 19, 2021
@ruiconti ruiconti self-assigned this Mar 19, 2021
@ruiconti ruiconti added the help wanted Extra attention is needed label Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design change A change that involves a change of current software design. Orthogonal to a refactor help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant