Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General review of authorization aggregate #7

Open
ruiconti opened this issue Mar 19, 2021 · 0 comments
Open

General review of authorization aggregate #7

ruiconti opened this issue Mar 19, 2021 · 0 comments
Assignees
Labels
being tackled Someone has already started working in this issue. Contact assignee to avoid rework. crucial refactor Change implementation details but keep functionality stale. review Pieces of code that needs to be carefully reviewed
Milestone

Comments

@ruiconti
Copy link
Contributor

ruiconti commented Mar 19, 2021

Issue

Authorization aggregate can be thoroughly reviewed in order to spot inconsistencies in design principles. As well as fast improvements that ought to be made. However, this won't improve on permissions functionality as it is a bigger and more complex matter. A superficial review has already lended a few TODO that should be addressed.

Proposed solution

Overall navigation of code to detect and improve on inconsistencies, anti-patterns, etc.

This issue may spawn many others 🚨

@ruiconti ruiconti added refactor Change implementation details but keep functionality stale. review Pieces of code that needs to be carefully reviewed labels Mar 19, 2021
@ruiconti ruiconti added this to the Going Public milestone Mar 19, 2021
@ruiconti ruiconti self-assigned this Mar 19, 2021
@ruiconti ruiconti added crucial being tackled Someone has already started working in this issue. Contact assignee to avoid rework. labels Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
being tackled Someone has already started working in this issue. Contact assignee to avoid rework. crucial refactor Change implementation details but keep functionality stale. review Pieces of code that needs to be carefully reviewed
Projects
None yet
Development

No branches or pull requests

1 participant