Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stricter ESLint rules and add to CI pipeline #36

Closed
anton-trunov opened this issue Jun 4, 2024 · 4 comments · Fixed by #58
Closed

Implement stricter ESLint rules and add to CI pipeline #36

anton-trunov opened this issue Jun 4, 2024 · 4 comments · Fixed by #58

Comments

@anton-trunov
Copy link
Member

anton-trunov commented Jun 4, 2024 •
edited
Loading

and fix any issues ESLint finds.

For instance, you might want to reuse the ESLint setup from Tact, especially

This is the relevant PR: tact-lang/tact#157
@anton-trunov
Copy link
Member Author

Any progress here?

@rahulyadav-57
Copy link
Member

ESLint is already set up in the project; now, I just need to integrate it with the CI pipeline.

@anton-trunov
Copy link
Member Author

Please make sure your ESLint checks for the IDE is in sync with the ones for the Tact compiler. It recently got some updates, see https://github.com/tact-lang/tact/blob/main/.eslintrc.cjs

@rahulyadav-57
Copy link
Member

Sure

@rahulyadav-57 rahulyadav-57 changed the title Add ESLint to CI Implement stricter ESLint rules and add to CI pipeline Jul 10, 2024
@rahulyadav-57 rahulyadav-57 mentioned this issue Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more strict ESLint rules, resolve linting errors and cleanup tact-lang/web-ide
2 participants
@anton-trunov @rahulyadav-57