Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Save Editable Page” output missing Formatting and Images #4

Open
sunjam opened this issue Feb 19, 2018 · 5 comments
Open

“Save Editable Page” output missing Formatting and Images #4

sunjam opened this issue Feb 19, 2018 · 5 comments

Comments

@sunjam
Copy link

sunjam commented Feb 19, 2018

Output of Save Editable Page
41e3f04a-6223-41c4-9e6b-766e7f7e0c2d
Output of Save Complete Page
e1866875-78e3-411c-bc61-bfd925413704

@uggrock
Copy link
Member

uggrock commented Feb 19, 2018

This is more or less the intended output of this functionality. If you open it in TagSpaces with HTML viewer with readability mode turned on, it will look much nicer. For now the saving functionality just saves the HTML with all the embedded images (img tags) as data urls.

In the future we may run the readability script before the saving of the HTML file, this will clean some of the unneeded blocks, but will also change heavily the page content ....

@sunjam
Copy link
Author

sunjam commented Feb 19, 2018 via email

@aproposnix
Copy link

@uggrock I opened a page in read mode (Firefox 59b10) and it saved very nicely from here (though the images don't show up).

It would definitely be nice to see some improved scripting to strip out useless elements and include the images.

@sunjam thanks for filing this one :)

@uggrock
Copy link
Member

uggrock commented Feb 20, 2018

Hi,
please find attached a zip containing a page I just created with the Firefox extension, it has one embedded image, please confirm you can read it. Can you please send me your results from saving pages?
sample-page.zip

@sunjam
Copy link
Author

sunjam commented Mar 3, 2018

Sample page seems okay, but having trouble with “Editable Page” save from the Nextcloud Discourse help forum.

Here is the help forum live page. and next is how it is clipped by Tagspaces webclipper as editable html. Had tore-save as pdf before I could upload it from my ios device...

app ideas - Nextcloud community.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants