Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark 'unit tests OK' in reviews when Unit Tests returned non-zero exit #12

Open
iamPHEN opened this issue Oct 16, 2015 · 0 comments

Comments

@iamPHEN
Copy link

iamPHEN commented Oct 16, 2015

Currently the error code isn't being checked when unit tests are ran.

https://github.com/tagview/arcanist-extensions/blob/master/tap_test_engine/src/TAPTestEngine.php#L17

I have little understanding about PHP, but here's my hacky workaround:

    list($error, $stdout, $stderr) = $future->resolve();

    if ($error <> 0) {
      $msg = "not ok 0 - Unit test returned non-zero exit\n";
      echo $msg;
      return $this->parseOutput($msg);
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant