Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getConfigFromAnySource('unit.engine.tap.command') only pulls first command #6

Open
elsigh opened this issue Apr 27, 2015 · 3 comments

Comments

@elsigh
Copy link

elsigh commented Apr 27, 2015

If you have two tap tests this line won't work, it pulls the first matching config line that matches "unit.engine.tap.command".

Why not pull from actual runtime config for this class and just call the option "command" - seems cleaner, no?

@elsigh
Copy link
Author

elsigh commented Apr 27, 2015

Oh I see, each engine doesn't have its own config. Maybe it should. ;0

@reu
Copy link
Member

reu commented Apr 30, 2015

Yeah, that's a hard problem to solve. The current implementation used to work, and Arcanist would pick the last defined one, looks like this behaviour was changed in more recent versions. Perhaps we should add something like a engine "name" when using MultiTestEngine, and then we could scope each config by this "name".

@elsigh
Copy link
Author

elsigh commented May 5, 2015

It seems like the instance object of an engine should be able to hold a localized configuration somehow.

jiparis pushed a commit to jiparis/arcanist-extensions that referenced this issue Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants