Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you accept a PR that adds a GoTestEngine? #9

Open
elsigh opened this issue May 5, 2015 · 1 comment · May be fixed by #10
Open

Would you accept a PR that adds a GoTestEngine? #9

elsigh opened this issue May 5, 2015 · 1 comment · May be fixed by #10

Comments

@elsigh
Copy link

elsigh commented May 5, 2015

While I know it's not precisely an extendible test engine like TapTestEngine, it does only work in the MultiTestEngine context.. I'm happy to send a PR if you're cool with it.

final class GoTestEngine extends ArcanistUnitTestEngine {
public function run() {
$command = $this->getConfigurationManager()->getConfigFromAnySource('unit.engine.go.command');
$future = new ExecFuture($command);

do {
  list($stdout, $stderr) = $future->read();
  echo $stdout;
  echo $stderr;
  sleep(0.5);
} while (!$future->isReady());

list($error, $stdout, $stderr) = $future->resolve();

$parser = new ArcanistGoTestResultParser();
return $parser->parseTestResults("", $stdout);

}
}

@elsigh elsigh linked a pull request May 5, 2015 that will close this issue
@reu
Copy link
Member

reu commented May 8, 2015

Sure thing! Sorry for the delay, I am not being able to review your PRs, I will take a look at this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@reu @elsigh and others