Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrichment "admonitions" #1234

Open
3 of 8 tasks
mhluongo opened this issue Mar 23, 2022 · 0 comments
Open
3 of 8 tasks

Enrichment "admonitions" #1234

mhluongo opened this issue Mar 23, 2022 · 0 comments
Labels
🐾 tracking Used to collect or track larger chunks of work Type: Enhancement New feature or request Type: Plumbing Internal product improvements Type: Security Security-related concerns & enhancements

Comments

@mhluongo
Copy link
Contributor

mhluongo commented Mar 23, 2022

The EnrichmentService includes annotations about transaction requests and addresses. It should also include the idea of "admonitions" — annotations that the UI should show as warnings, perhaps even requiring a user to agree.

Some example admonitions.

H/t @Shadowfiend for the name and offline discussion.

@mhluongo mhluongo added Type: Enhancement New feature or request Type: Plumbing Internal product improvements labels Mar 23, 2022
@mhluongo mhluongo added the 🐾 tracking Used to collect or track larger chunks of work label May 24, 2022
mhluongo added a commit that referenced this issue Aug 8, 2022
There's no reason to ever skip returning a tx annotation — we can always
fall back to a generic contract interaction.

Refs #1234
mhluongo added a commit that referenced this issue Aug 8, 2022
mhluongo added a commit that referenced this issue Aug 8, 2022
mhluongo added a commit that referenced this issue Aug 8, 2022
There's no reason to ever skip returning a tx annotation — we can always
fall back to a generic contract interaction.

Refs #1234
mhluongo added a commit that referenced this issue Aug 8, 2022
mhluongo added a commit that referenced this issue Aug 8, 2022
@mhluongo mhluongo added the Type: Security Security-related concerns & enhancements label Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐾 tracking Used to collect or track larger chunks of work Type: Enhancement New feature or request Type: Plumbing Internal product improvements Type: Security Security-related concerns & enhancements
Projects
None yet
Development

No branches or pull requests

1 participant