Logging service

[mhluongo]

We need a single service that...

• Wraps basic logging
• Persists logs for export
• Can disable console printing for production builds
• Can act as a single point for future opt-in telemetry

[itsrachelfish]

@mhluongo Since we are already using IndexDB for storing account and transaction information, I think it would make sense to persist log files in IndexDB as well. Any objections?

[mhluongo]

None, but let me open the "pre-issue" to this.. I have a feeling you'll want to do this in two pieces.

EDIT:

Here it is

#210

[Shadowfiend]

Want to flag a concern that persistent rather than ephemeral logs may require much more careful usage of logging functions to avoid increasing the danger if the extension storage is compromised somehow.

[greg-nagy]

I think I would go with session storage usage because logs can accumulate to terrible sizes and we are not really interested in logs from ages ago

I was not sure if it's available from the background script but it seems so based on the mdn js api list for bg scripts
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API

[0xDaedalus]

We have pieces of this in logger.ts as well as in analytics service now. The only thing completely missing is Can disable console printing for production builds which could be a nice thing to have but might make troubleshooting user issues more difficult if we don't do it carefully.

[beemeeupnow]

Would it be possible to have a toggle in the settings page for console logs?

If eventually disabling them by default is still a goal that would make the change extremely simple when the time comes.

[hyphenized]

Would it be possible to have a toggle in the settings page for console logs?

If eventually disabling them by default is still a goal that would make the change extremely simple when the time comes.

True but I'm not sure we'd want to allow disabling them completely. It's much simpler for a user who just ran into an issue to go to settings and export logs, rather than enable logs and try to reproduce the issue again.

That said, logging definitely needs some work. There seems to be a lot of unnecessary noise so the log level for certain things might not be entirely accurate 🤔

[Shadowfiend]

To be clear, that bullet refers to not calling console.* in production, not disabling logging for export purposes. So folks would still be able to export logs, but if eg there's an extension observing logs in dev tools it wouldn't see production logs. Mostly just a way to reduce attack surface.

[hyphenized]

Ah, makes sense, thanks for making that clear