From 6ee68baf99cafe6bcf097497e76a0defca28221c Mon Sep 17 00:00:00 2001 From: Bernat Canal Garceran Date: Mon, 20 May 2024 09:10:23 +0200 Subject: [PATCH 1/2] ci(repo): add snaefell-ui package (#17228) Co-authored-by: Korbinian Co-authored-by: Daniel Wang <99078276+dantaik@users.noreply.github.com> Co-authored-by: Daniel Wang --- .github/workflows/repo--validate-pr-title.yml | 1 + packages/snaefell-ui/package.json | 11 +++++++++++ pnpm-lock.yaml | 2 ++ release-please-config.json | 3 ++- 4 files changed, 16 insertions(+), 1 deletion(-) create mode 100644 packages/snaefell-ui/package.json diff --git a/.github/workflows/repo--validate-pr-title.yml b/.github/workflows/repo--validate-pr-title.yml index 0ac59b4d3d9..a26ad5b010f 100644 --- a/.github/workflows/repo--validate-pr-title.yml +++ b/.github/workflows/repo--validate-pr-title.yml @@ -42,6 +42,7 @@ jobs: relayer taikoon snaefell-nft + snaefell-ui ui-lib taiko-client supplementary-contracts diff --git a/packages/snaefell-ui/package.json b/packages/snaefell-ui/package.json new file mode 100644 index 00000000000..1b3f574ffb9 --- /dev/null +++ b/packages/snaefell-ui/package.json @@ -0,0 +1,11 @@ +{ + "name": "snaefell-ui", + "version": "1.0.0", + "description": "", + "main": "index.js", + "scripts": { + "test": "echo \"Error: no test specified\" && exit 1" + }, + "author": "", + "license": "ISC" +} diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 80ffe71e81a..7fdf618af8a 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -377,6 +377,8 @@ importers: packages/snaefell-nft: {} + packages/snaefell-ui: {} + packages/supplementary-contracts: dependencies: '@openzeppelin/contracts': diff --git a/release-please-config.json b/release-please-config.json index 367eb9aed0e..c3d3546b5c4 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -14,7 +14,8 @@ "packages/taikoon-ui": {}, "packages/taiko-client": {}, "packages/supplementary-contracts": {}, - "packages/snaefell-nft": {} + "packages/snaefell-nft": {}, + "packages/snaefell-ui": {} }, "separate-pull-requests": true } From 9eae95f854f2b1724b729c4b3a9edf6046efd80b Mon Sep 17 00:00:00 2001 From: Daniel Wang <99078276+dantaik@users.noreply.github.com> Date: Mon, 20 May 2024 15:52:47 +0800 Subject: [PATCH 2/2] refactor(repo): remove `snaefell-nft` package (#17255) --- .github/workflows/repo--validate-pr-title.yml | 1 - .github/workflows/taikoon.yml | 3 +++ README.md | 2 +- packages/snaefell-nft/package.json | 13 ------------- pnpm-lock.yaml | 2 -- release-please-config.json | 1 - 6 files changed, 4 insertions(+), 18 deletions(-) delete mode 100644 packages/snaefell-nft/package.json diff --git a/.github/workflows/repo--validate-pr-title.yml b/.github/workflows/repo--validate-pr-title.yml index a26ad5b010f..1a58f1fc18a 100644 --- a/.github/workflows/repo--validate-pr-title.yml +++ b/.github/workflows/repo--validate-pr-title.yml @@ -41,7 +41,6 @@ jobs: protocol relayer taikoon - snaefell-nft snaefell-ui ui-lib taiko-client diff --git a/.github/workflows/taikoon.yml b/.github/workflows/taikoon.yml index ae37b835246..bf7d8071f3a 100644 --- a/.github/workflows/taikoon.yml +++ b/.github/workflows/taikoon.yml @@ -5,6 +5,9 @@ on: branches: [main] paths: - "packages/taikoon/**" + pull_request: + paths: + - "packages/taikoon/**" jobs: build-taikoon: diff --git a/README.md b/README.md index 00a09c3b58a..c9fc3e1c2ed 100644 --- a/README.md +++ b/README.md @@ -48,7 +48,7 @@ taiko-mono/ │ ├── relayer: Bridge backend relayer. │ ├── supplementary-contracts: Supplementary smart contracts that are not part of the Taiko rollup protocol. │ ├── taiko-client: Taiko client implementation in Go. -│ ├── taikoon: Taikoon NFT contracts. +│ ├── taikoon: Taikoon and other NFT contracts. │ └── taikoon-ui: Taikoon NFT UI. ... diff --git a/packages/snaefell-nft/package.json b/packages/snaefell-nft/package.json deleted file mode 100644 index b02e5c45278..00000000000 --- a/packages/snaefell-nft/package.json +++ /dev/null @@ -1,13 +0,0 @@ -{ - "name": "snaefell-nft", - "version": "1.0.0", - "description": "", - "main": "index.js", - "dependencies": {}, - "devDependencies": {}, - "scripts": { - "test": "echo \"Error: no test specified\" && exit 1" - }, - "author": "", - "license": "ISC" -} diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 7fdf618af8a..8b1c778b368 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -375,8 +375,6 @@ importers: packages/relayer: {} - packages/snaefell-nft: {} - packages/snaefell-ui: {} packages/supplementary-contracts: diff --git a/release-please-config.json b/release-please-config.json index c3d3546b5c4..f2e9a0371c8 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -14,7 +14,6 @@ "packages/taikoon-ui": {}, "packages/taiko-client": {}, "packages/supplementary-contracts": {}, - "packages/snaefell-nft": {}, "packages/snaefell-ui": {} }, "separate-pull-requests": true