diff --git a/Sources/DangerSwiftPeriphery/DangerDSL+Extensions.swift b/Sources/DangerSwiftPeriphery/DangerDSL+Extensions.swift index 7c1a801..5d027f2 100644 --- a/Sources/DangerSwiftPeriphery/DangerDSL+Extensions.swift +++ b/Sources/DangerSwiftPeriphery/DangerDSL+Extensions.swift @@ -1,6 +1,6 @@ import Danger -extension DangerDSL: DangerCommentable { +extension DangerDSL: ViolationNotifier { func warn(violation: Violation) { warn(message: violation.message, file: violation.filePath, diff --git a/Sources/DangerSwiftPeriphery/DangerPeriphery.swift b/Sources/DangerSwiftPeriphery/DangerPeriphery.swift index 3d6a6f8..ccb2308 100644 --- a/Sources/DangerSwiftPeriphery/DangerPeriphery.swift +++ b/Sources/DangerSwiftPeriphery/DangerPeriphery.swift @@ -89,9 +89,9 @@ public enum DangerPeriphery { } } - static func handleScanResult(_ scanResult: Result<[Violation], Error>, - danger: DC, - shouldComment: Bool) { + static func handleScanResult(_ scanResult: Result<[Violation], Error>, + danger: Notifier, + shouldComment: Bool) { guard shouldComment else { return } switch scanResult { case .success(let violations): diff --git a/Sources/DangerSwiftPeriphery/DangerCommentable.swift b/Sources/DangerSwiftPeriphery/ViolationNotifier.swift similarity index 75% rename from Sources/DangerSwiftPeriphery/DangerCommentable.swift rename to Sources/DangerSwiftPeriphery/ViolationNotifier.swift index fac0276..5947ae4 100644 --- a/Sources/DangerSwiftPeriphery/DangerCommentable.swift +++ b/Sources/DangerSwiftPeriphery/ViolationNotifier.swift @@ -1,6 +1,6 @@ import Foundation -protocol DangerCommentable { +protocol ViolationNotifier { func warn(violation: Violation) func fail(_ message: String) } diff --git a/Tests/DangerSwiftPeripheryTests/DangerSwiftPeripheryTests.swift b/Tests/DangerSwiftPeripheryTests/DangerSwiftPeripheryTests.swift index 838b0ad..3d96a60 100644 --- a/Tests/DangerSwiftPeripheryTests/DangerSwiftPeripheryTests.swift +++ b/Tests/DangerSwiftPeripheryTests/DangerSwiftPeripheryTests.swift @@ -6,7 +6,7 @@ final class DangerSwiftPeripheryTests: XCTestCase { private var scanExecutor: PeripheryScanExecutableMock! private var outputParser: CheckstyleOutputParsableMock! private var diffProvider: PullRequestDiffProvidableMock! - private var dangerCommentable: DangerCommentableMock! + private var dangerCommentable: ViolationNotifierMock! override func setUp() { super.setUp() @@ -14,7 +14,7 @@ final class DangerSwiftPeripheryTests: XCTestCase { scanExecutor = PeripheryScanExecutableMock() outputParser = CheckstyleOutputParsableMock() diffProvider = PullRequestDiffProvidableMock() - dangerCommentable = DangerCommentableMock() + dangerCommentable = ViolationNotifierMock() } func testScanErrorOccurredWhileScanning() throws { diff --git a/Tests/DangerSwiftPeripheryTests/Mocks/DangerCommentableMock.swift b/Tests/DangerSwiftPeripheryTests/Mocks/ViolationNotifierMock.swift similarity index 92% rename from Tests/DangerSwiftPeripheryTests/Mocks/DangerCommentableMock.swift rename to Tests/DangerSwiftPeripheryTests/Mocks/ViolationNotifierMock.swift index 7fc8cd7..5fd238a 100644 --- a/Tests/DangerSwiftPeripheryTests/Mocks/DangerCommentableMock.swift +++ b/Tests/DangerSwiftPeripheryTests/Mocks/ViolationNotifierMock.swift @@ -5,7 +5,7 @@ import Foundation @testable import DangerSwiftPeriphery -final class DangerCommentableMock: DangerCommentable { +final class ViolationNotifierMock: ViolationNotifier { var warnHandler: ((Violation) -> Void)? var failHandler: ((String) -> Void)? private(set) var warnCallCount = 0