You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi,
I was comparing this Tax class to the API for Calculating sales tax for an order and noticed shouldn't certain fields be nullable? For example, Tax.Amount and Tax.Shipping should be of type decimal?, right? Shouldn't any parameter that is considered optional in the API docs be nullable? When serializing any classes before sending them to the API (
), the default values for certain types are being set and sent instead of null (or nothing if NullValueHandling = NullValueHandling.Ignore is being set).
This should be changed in all classes that have optional API parameters not just the Tax class referenced above.
Thanks!
The text was updated successfully, but these errors were encountered:
Hi,
I was comparing this
Tax
class to the API for Calculating sales tax for an order and noticed shouldn't certain fields be nullable? For example,Tax.Amount
andTax.Shipping
should be of typedecimal?
, right? Shouldn't any parameter that is considered optional in the API docs be nullable? When serializing any classes before sending them to the API (taxjar.net/src/Taxjar/TaxjarApi.cs
Line 120 in 02a0d1c
null
(or nothing ifNullValueHandling = NullValueHandling.Ignore
is being set).This should be changed in all classes that have optional API parameters not just the Tax class referenced above.
Thanks!
The text was updated successfully, but these errors were encountered: