Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestSharp vulnerability #72

Open
Tom-Knighton opened this issue Dec 19, 2024 · 2 comments
Open

RestSharp vulnerability #72

Tom-Knighton opened this issue Dec 19, 2024 · 2 comments

Comments

@Tom-Knighton
Copy link

Issue

This library has a dependency on RestSharp >= 108.0.3

There is a vulnerability with RestSharp library that was fixed in 112.0.0 CVE-2024-45302 - however this version of RestSharp causes a crash when initializing an instance of TaxjarApi due to a constructor's signature having changed (presumably)

Repro:

var api = new TaxjarApi("....api key");

Exception:

System.MissingMethodException: Method not found: 'Void RestSharp.RestClient..ctor(RestSharp.RestClientOptions, System.Action`1<System.Net.Http.Headers.HttpRequestHeaders>)'.
   at Taxjar.TaxjarApi..ctor(String token, Object parameters)
...

Would be great if the version of RestSharp used by this library is updated, especially as users of this library can pass in headers into the instance of the RestSharp client created by this library.

@mhaerle
Copy link

mhaerle commented Dec 19, 2024

I am seeing this too, I don't want to revert to a vulnerable version of RestSharp just to get the TaxJar client to work. It would be great if the could get this fixed and pushed to nuget.

@adramalech
Copy link

adramalech commented Jan 10, 2025

Seeing same problem. Further investigation on the project shows RestSharp will work v110.2.0 but will break on v111.0.0+ without code changes to Taxjar.net library code. However, still seeing the original issue posted here on v110.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants