Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Specs] Make explicit Pset constraint for SwapRequest #43

Open
altafan opened this issue Dec 23, 2021 · 0 comments
Open

[Specs] Make explicit Pset constraint for SwapRequest #43

altafan opened this issue Dec 23, 2021 · 0 comments

Comments

@altafan
Copy link
Contributor

altafan commented Dec 23, 2021

The Trade protocol spec must make clear that the inputs of a partial transaction sent within a TradePropose message must contain the RedeemScript/WitnessScript for every P2SH/P2WSH input.

This is because by design the daemon is in charge of adding the network fees and without these info, it simply cannot do its job correctly.

Making this explicit forces both parties to make sure that the constrain is respected:

  • the daemon must reject the partial transaction because it's malformed in case its partial inputs miss those fields
  • the client must enforce this condition to sanitize the transaction before making a TradePropose request
@tiero tiero changed the title Make explicit Pset constraint Make explicit Pset constraint for SwapRequest Dec 28, 2021
@tiero tiero transferred this issue from tdex-network/tdex-specs Apr 11, 2022
@tiero tiero changed the title Make explicit Pset constraint for SwapRequest [Specs] Make explicit Pset constraint for SwapRequest Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant