You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Trade protocol spec must make clear that the inputs of a partial transaction sent within a TradePropose message must contain the RedeemScript/WitnessScript for every P2SH/P2WSH input.
This is because by design the daemon is in charge of adding the network fees and without these info, it simply cannot do its job correctly.
Making this explicit forces both parties to make sure that the constrain is respected:
the daemon must reject the partial transaction because it's malformed in case its partial inputs miss those fields
the client must enforce this condition to sanitize the transaction before making a TradePropose request
The text was updated successfully, but these errors were encountered:
tiero
changed the title
Make explicit Pset constraint
Make explicit Pset constraint for SwapRequest
Dec 28, 2021
tiero
transferred this issue from tdex-network/tdex-specs
Apr 11, 2022
tiero
changed the title
Make explicit Pset constraint for SwapRequest
[Specs] Make explicit Pset constraint for SwapRequest
Apr 11, 2022
The Trade protocol spec must make clear that the inputs of a partial transaction sent within a TradePropose message must contain the RedeemScript/WitnessScript for every P2SH/P2WSH input.
This is because by design the daemon is in charge of adding the network fees and without these info, it simply cannot do its job correctly.
Making this explicit forces both parties to make sure that the constrain is respected:
The text was updated successfully, but these errors were encountered: