-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[specs] Update BOTD#4 #50
Comments
@tiero shall we just update the spec or we want to add some kind of versioning for having a doc for both the "old" and "new" versions of this BOTD in the dev portal? |
We can simply link to old commit ie. "If you looking for v1 spec go to this link on Github" |
Alright. Another thing I want to point out is that we added We should refer to these actors as provider and trader (which are concepts of BOTD#4) to properly explain these 2 new fields of the SwapRequest message. Maybe it's more appropriate to add these fields to the ProposeTradeRequest message (BOTD#4) since they seem to be related more to the trade context rather than the swap one? |
Agreed let's move there |
We must update BOTD#3 by moving to psetv2 (drop in/out blinding keys and add unblinded inputs) and by adding fee asset and amount to the swap request.
It is also very important to describe thoroughly how to use these new fields, in particular how to correctly charge the fees to either amount_p or amount_r.
The text was updated successfully, but these errors were encountered: