Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[specs] Update BOTD#4 #50

Open
altafan opened this issue Mar 21, 2023 · 4 comments
Open

[specs] Update BOTD#4 #50

altafan opened this issue Mar 21, 2023 · 4 comments

Comments

@altafan
Copy link
Contributor

altafan commented Mar 21, 2023

We must update BOTD#3 by moving to psetv2 (drop in/out blinding keys and add unblinded inputs) and by adding fee asset and amount to the swap request.

It is also very important to describe thoroughly how to use these new fields, in particular how to correctly charge the fees to either amount_p or amount_r.

@altafan
Copy link
Contributor Author

altafan commented Mar 21, 2023

@tiero shall we just update the spec or we want to add some kind of versioning for having a doc for both the "old" and "new" versions of this BOTD in the dev portal?

@tiero
Copy link
Contributor

tiero commented Mar 21, 2023

@tiero shall we just update the spec or we want to add some kind of versioning for having a doc for both the "old" and "new" versions of this BOTD in the dev portal?

We can simply link to old commit

ie. "If you looking for v1 spec go to this link on Github"

@altafan
Copy link
Contributor Author

altafan commented Mar 21, 2023

Alright.

Another thing I want to point out is that we added fee_asset and fee_amount to the SwapRequest message but it's hard to give an explanation for them since the current doc refers to Alice and Bob as generic proposer and receiver of a swap.

We should refer to these actors as provider and trader (which are concepts of BOTD#4) to properly explain these 2 new fields of the SwapRequest message.

Maybe it's more appropriate to add these fields to the ProposeTradeRequest message (BOTD#4) since they seem to be related more to the trade context rather than the swap one?

@tiero
Copy link
Contributor

tiero commented Mar 21, 2023

related more to the trade context rather than the swap one

Agreed let's move there

@altafan altafan changed the title [specs] Update BOTD#3 [specs] Update BOTD#4 Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants