From 12ec28921939a4e79592ab43f5205a24581853e9 Mon Sep 17 00:00:00 2001 From: 231tr0n Date: Mon, 4 Mar 2024 13:35:44 +0530 Subject: [PATCH] fix(terminal-char): unwanted terminal characters being written to the terminal --- README.md | 6 +++--- package.json | 2 +- src/lib/components/Terminal.svelte | 6 ++++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index c3499bd..fa69c2f 100644 --- a/README.md +++ b/README.md @@ -42,10 +42,12 @@ npm run test npm run commitlint ``` -### Important points to note when contributing. +## Important points to note when contributing. - Running the below command can be useful for easily creating commit messages following conventional commiting format. - `npm run commit` +- Running the below command can be useful if the github action fails to find out what is the error. + - `npm run ci` - Github action will fail in the following scenarios 1. Eslint linting error 2. Prettier formatting error @@ -53,5 +55,3 @@ npm run commitlint 4. Test error 5. Commit message not following [conventional commiting format](https://conventionalcommits.org) - In the event of failure of the github action, go to its logs and check which job has failed and what is the error printed so that it can be debugged and resolved. -- Running the below command can be useful if the github action fails. - - `npm run ci` diff --git a/package.json b/package.json index 1b8657d..deb8443 100644 --- a/package.json +++ b/package.json @@ -42,7 +42,7 @@ "svelte-check": "^3.6.6", "tslib": "^2.6.2", "typescript": "^5.3.3", - "unlighthouse": "^0.11.3", + "unlighthouse": "^0.11.4", "vite": "^5.1.4", "vitest": "^1.3.1" }, diff --git a/src/lib/components/Terminal.svelte b/src/lib/components/Terminal.svelte index a66b81b..d03fdac 100644 --- a/src/lib/components/Terminal.svelte +++ b/src/lib/components/Terminal.svelte @@ -347,8 +347,10 @@ term.write('\b \b'); } } else { - typedPrompt += e; - term.write(e); + if (e.charCodeAt(0) > 31 && e.charCodeAt(0) < 127) { + typedPrompt += e; + term.write(e); + } } });