Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsonrpc.js doesn't create global variable jsonrpc in browser #16

Open
ghost opened this issue Oct 26, 2019 · 2 comments · May be fixed by #17
Open

jsonrpc.js doesn't create global variable jsonrpc in browser #16

ghost opened this issue Oct 26, 2019 · 2 comments · May be fixed by #17

Comments

@ghost
Copy link

ghost commented Oct 26, 2019

Unable to use jsonrpc.js umd file in browsers:

Uncaught ReferenceError: jsonrpc is not defined
@ghost
Copy link
Author

ghost commented Oct 26, 2019

Also impossible to use with rollup.js

[!] Error: 'parse' is not exported by ./node_modules/jsonrpc-lite/jsonrpc.js

antongolub added a commit to antongolub/jsonrpc-lite that referenced this issue Oct 27, 2019
@antongolub
fix: expose jsonrpc lib as global variable
56fe79d 
closes teambition#16
antongolub added a commit to antongolub/jsonrpc-lite that referenced this issue Oct 27, 2019
@antongolub
fix: expose jsonrpc lib as global variable
d7b3b34 
closes teambition#16
@antongolub
Copy link
Contributor

@makoven , could you test the patch proposal? Just replace node_modules/jsonrpc-lite with this inners and check this out.

@antongolub antongolub linked a pull request Oct 28, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add global jsonrpc ref for umd bundle and fix webpack warning antongolub/jsonrpc-lite
1 participant
@antongolub