From 8e1e361e19c6eab94721ea47d6731443393268d4 Mon Sep 17 00:00:00 2001 From: TheScarastic Date: Wed, 19 Jan 2022 09:36:35 +0530 Subject: [PATCH] RealmeDirac: Adapt to S style * Use Theme.SubSettingsBase for theme * Replace PreferenceActivity with CollapsingToolbarBaseActivity * Add Titles to prefernce screen * Remove onOptionsItemSelected and where neccessary move to activity Signed-off-by: chiru2000 Signed-off-by: Aryan Sinha --- Android.mk | 2 + AndroidManifest.xml | 2 +- res/values/strings.xml | 9 +-- res/xml/dirac_settings.xml | 9 ++- src/com/realme/dirac/DiracActivity.java | 7 +- .../realme/dirac/DiracSettingsFragment.java | 66 ++++--------------- 6 files changed, 28 insertions(+), 67 deletions(-) diff --git a/Android.mk b/Android.mk index 0892863..84692be 100644 --- a/Android.mk +++ b/Android.mk @@ -21,6 +21,8 @@ LOCAL_RESOURCE_DIR := \ LOCAL_PROGUARD_FLAG_FILES := proguard.flags +include frameworks/base/packages/SettingsLib/common.mk + include $(BUILD_PACKAGE) include $(call all-makefiles-under,$(LOCAL_PATH)) diff --git a/AndroidManifest.xml b/AndroidManifest.xml index f5d3884..6a96cc9 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -45,7 +45,7 @@ android:name=".DiracActivity" android:label="@string/dirac_title" android:icon="@drawable/ic_headphone" - android:theme="@style/Theme.Main" + android:theme="@style/Theme.SubSettingsBase" android:exported="true"> diff --git a/res/values/strings.xml b/res/values/strings.xml index 19ce454..e54ac81 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -15,17 +15,12 @@ limitations under the License. --> - - On - - - Off - realme Dirac - realme-Dirac Sound Enhancer + Enable dirac + realme Dirac Sound Enhancer Optimize audio quality Choose headphones type Choose a preset diff --git a/res/xml/dirac_settings.xml b/res/xml/dirac_settings.xml index 2fab929..4c5f288 100644 --- a/res/xml/dirac_settings.xml +++ b/res/xml/dirac_settings.xml @@ -14,7 +14,14 @@ See the License for the specific language governing permissions and limitations under the License. --> - + + + { - switchWidget.setChecked(!switchWidget.isChecked()); - mSwitchBar.setActivated(switchWidget.isChecked()); - }); - } - @Override public boolean onPreferenceChange(Preference preference, Object newValue) { switch (preference.getKey()) { @@ -118,9 +84,8 @@ public boolean onPreferenceChange(Preference preference, Object newValue) { } @Override - public void onCheckedChanged(CompoundButton compoundButton, boolean isChecked) { + public void onSwitchChanged(Switch switchView, boolean isChecked) { mDiracUtils.setEnabled(isChecked); - mTextView.setText(getString(isChecked ? R.string.switch_bar_on : R.string.switch_bar_off)); if (isChecked){ mSwitchBar.setEnabled(false); mHandler.postDelayed(new Runnable() { @@ -137,19 +102,10 @@ public void run() { setEnabled(isChecked); } } - + private void setEnabled(boolean enabled){ - mSwitchBar.setActivated(enabled); + mSwitchBar.setChecked(enabled); mHeadsetType.setEnabled(enabled); mPreset.setEnabled(enabled); } - - @Override - public boolean onOptionsItemSelected(MenuItem item) { - if (item.getItemId() == android.R.id.home) { - getActivity().onBackPressed(); - return true; - } - return false; - } }