-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending json output with new values #9
Comments
Honestly it has been a while since I've worked on this, so not sure why those tests are commented out...I suspect there was an issue with using them, but not sure. If we can get checks per-line working, I wouldn't be opposed to adding additional items, provided there is a graceful failure mode when they aren't there. I wish I had a better way to test this than hooking it up to my live instance. Do you know if there is a test input stream/instance I could run, maybe in a docker container? |
I've successfully extended the output to include UV index, radiation and soil moisture by adding the following lines: I found the easiest way to obtain the required obstype was to open the weewx.sdb in a SQLite editor and look at the headings. The tests are commented out as that's how conditional statements in inc files work. |
I'm investigating how to add additional values to the json output. Specifically, I'm looking at air quality-related values from the extended schema. Seems I would add values to https://github.com/teeks99/weewx-json/blob/main/skins/JSON/weewx.json.tmpl and they should start showing up?
I see the tests
if $current.windDir.has_data
commented out is that for performance or any other reason?Are PRs that add data from extended_schema welcome?
What about optional plugins with the tests for values enabled?
Thanks for this useful plugin!
Blake
The text was updated successfully, but these errors were encountered: