From 588d2aa1802eb72a76157741480142bcf2c7a12e Mon Sep 17 00:00:00 2001 From: Patryk Strusiewicz-Surmacki Date: Mon, 15 Jul 2024 12:34:52 +0200 Subject: [PATCH] Fixed tests Signed-off-by: Patryk Strusiewicz-Surmacki --- pkg/reconciler/reconciler_test.go | 31 ++++++++++++++++++++++++++++++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/pkg/reconciler/reconciler_test.go b/pkg/reconciler/reconciler_test.go index 602127d..b910570 100644 --- a/pkg/reconciler/reconciler_test.go +++ b/pkg/reconciler/reconciler_test.go @@ -133,9 +133,26 @@ var ( } ` - mockctrl *gomock.Controller + mockctrl *gomock.Controller + tmpDir string + testConfig string ) +const operatorConfigEnv = "OPERATOR_CONFIG" + +var _ = BeforeSuite(func() { + var err error + tmpDir, err = os.MkdirTemp(".", "testdata") + Expect(err).ToNot(HaveOccurred()) + testConfig = tmpDir + "/config.yaml" + os.WriteFile(testConfig, []byte{}, 0o644) //empty config +}) + +var _ = AfterSuite(func() { + err := os.RemoveAll(tmpDir) + Expect(err).ToNot(HaveOccurred()) +}) + func TestReconciler(t *testing.T) { RegisterFailHandler(Fail) mockctrl = gomock.NewController(t) @@ -234,6 +251,7 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { Expect(r).To(BeNil()) }) It("create new reconciler", func() { + os.Setenv(operatorConfigEnv, testConfig) frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) c := createClient() frrManagerMock.EXPECT().Init().Return(nil) @@ -241,10 +259,12 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { frrManagerMock, nl.NewManager(mock_nl.NewMockToolkitInterface(mockctrl))) Expect(err).ToNot(HaveOccurred()) Expect(r).ToNot(BeNil()) + os.Unsetenv(operatorConfigEnv) }) }) Context("Reconcile() should", func() { It("return no error if there is no config to reconcile", func() { + os.Setenv(operatorConfigEnv, testConfig) frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) c := createClient() frrManagerMock.EXPECT().Init().Return(nil) @@ -254,8 +274,10 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { Expect(r).ToNot(BeNil()) err = r.Reconcile(context.TODO()) Expect(err).ToNot(HaveOccurred()) + os.Unsetenv(operatorConfigEnv) }) It("return no error if there is no config to reconcile", func() { + os.Setenv(operatorConfigEnv, testConfig) frrManagerMock := mock_frr.NewMockManagerInterface(mockctrl) c := createClient() frrManagerMock.EXPECT().Init().Return(nil) @@ -265,8 +287,10 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { Expect(r).ToNot(BeNil()) err = r.Reconcile(context.TODO()) Expect(err).ToNot(HaveOccurred()) + os.Unsetenv(operatorConfigEnv) }) It("return error if cannot configure FRR", func() { + os.Setenv(operatorConfigEnv, testConfig) os.Setenv(healthcheck.NodenameEnv, "test-node") fakeNNC := &v1alpha1.NodeNetworkConfigList{} err := json.Unmarshal([]byte(fakeNNCJSON), fakeNNC) @@ -285,8 +309,10 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { err = r.Reconcile(context.TODO()) Expect(err).To(HaveOccurred()) os.Unsetenv(healthcheck.NodenameEnv) + os.Unsetenv(operatorConfigEnv) }) It("return error if failed to reload FRR", func() { + os.Setenv(operatorConfigEnv, testConfig) os.Setenv(healthcheck.NodenameEnv, "test-node") fakeNNC := &v1alpha1.NodeNetworkConfigList{} err := json.Unmarshal([]byte(fakeNNCJSON), fakeNNC) @@ -306,8 +332,10 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { err = r.Reconcile(context.TODO()) Expect(err).To(HaveOccurred()) os.Unsetenv(healthcheck.NodenameEnv) + os.Unsetenv(operatorConfigEnv) }) It("return error if cannot configure networking", func() { + os.Setenv(operatorConfigEnv, testConfig) os.Setenv(healthcheck.NodenameEnv, "test-node") fakeNNC := &v1alpha1.NodeNetworkConfigList{} err := json.Unmarshal([]byte(fakeNNCJSON), fakeNNC) @@ -327,6 +355,7 @@ var _ = Describe("NodeNetworkConfigReconciler", func() { err = r.Reconcile(context.TODO()) Expect(err).To(HaveOccurred()) os.Unsetenv(healthcheck.NodenameEnv) + os.Unsetenv(operatorConfigEnv) }) }) })