bug : Fix connecting to Teloscan to metamask for the first time uses the old rpc #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [webpack](https://github.com/webpack/webpack) from 5.88.2 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.88.2...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [micromatch](https://github.com/micromatch/micromatch) from 4.0.5 to 4.0.8. - [Release notes](https://github.com/micromatch/micromatch/releases) - [Changelog](https://github.com/micromatch/micromatch/blob/master/CHANGELOG.md) - [Commits](micromatch/micromatch@4.0.5...4.0.8) --- updated-dependencies: - dependency-name: micromatch dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Dev to Master - Early transactions
…and_yarn/webpack-5.94.0 Bump webpack from 5.88.2 to 5.94.0
…and_yarn/micromatch-4.0.8 Bump micromatch from 4.0.5 to 4.0.8
Bumps [http-proxy-middleware](https://github.com/chimurai/http-proxy-middleware) from 2.0.6 to 2.0.7. - [Release notes](https://github.com/chimurai/http-proxy-middleware/releases) - [Changelog](https://github.com/chimurai/http-proxy-middleware/blob/v2.0.7/CHANGELOG.md) - [Commits](chimurai/http-proxy-middleware@v2.0.6...v2.0.7) --- updated-dependencies: - dependency-name: http-proxy-middleware dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…and_yarn/http-proxy-middleware-2.0.7 Bump http-proxy-middleware from 2.0.6 to 2.0.7
Improve Address Page Display and Contract Manager Optimization
dev to master
Release - Rename Antelope to Core and Add Network Redirection Handling
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you sir, we just changed the PR to point to our dev branch, will test and deploy. |
pmjanus
previously approved these changes
Dec 16, 2024
poplexity
dismissed
pmjanus’s stale review
The merge-base changed after approval.
|
This code was added in this PR: #917 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #890
Description
This PR fixes the issue that let users connect to old RPC when connecting to Metamask for the first time.
I added the new RPC from https://docs.telos.net/build/network-info/.
Mainnet : https://rpc.telos.net
Testnet : https://testnet.rpc.telos.net
Test scenarios
I opened this project in a brand new Google Chrome window and clicked on "Connect Wallet" to let it add the new RPC
I checked my account balance using the new RPC.
Checklist: