Skip to content
This repository has been archived by the owner on Dec 18, 2022. It is now read-only.

Support FreeDesktop dark mode preference #645

Open
2 tasks done
vchernin opened this issue Sep 26, 2021 · 5 comments
Open
2 tasks done

Support FreeDesktop dark mode preference #645

vchernin opened this issue Sep 26, 2021 · 5 comments
Labels
design Issues and pull requests concerning the design and overall look and feel of the project. enhancement Idea or request for new feature hacktoberfest Contributions meant for DigitalOcean's Hacktoberfest event.

Comments

@vchernin
Copy link

vchernin commented Sep 26, 2021

Guidelines

  • I have read the guidelines.

Version/Commit hash

No response

Describe the bug.

Enabling dark mode with traditional themes can be a subpar experience, since there is no real agreed upon standard for how dark mode should work on Linux.

Expected behavior

This is fixed by the introduction of FreeDesktop dark mode preference. See flatpak/xdg-desktop-portal#629 and https://blog.elementary.io/the-need-for-a-freedesktop-dark-style-preference/

This should mean more reliable and consistent dark mode behaviour.
Likely needs support in the toolkit/UI library, so this is probably blocked on a decision in https://github.com/tenacityteam/tenacity/issues/572

OS

No response

Additional context

No response

This issue is not a duplicate

  • I have confirmed this issue isn't a duplicate.
@vchernin vchernin added the bug Some kind of fixable problem was encountered label Sep 26, 2021
@n0toose
Copy link
Member

n0toose commented Sep 27, 2021

This could work much better and in a similar manner as https://github.com/tenacityteam/tenacity/pull/608.

@n0toose
Copy link
Member

n0toose commented Sep 27, 2021

Went on the thread to thank the very nice freedesktop people for working on that. I'll see to it.

@n0toose n0toose added design Issues and pull requests concerning the design and overall look and feel of the project. enhancement Idea or request for new feature and removed bug Some kind of fixable problem was encountered labels Sep 28, 2021
@BrainBlasted
Copy link

Here's some example code on how to do this with SDL and GDBus, courtesy of Alexander Mikahaylenko: https://gist.github.com/BrainBlasted/931b763fc3dcdec2fc55a4ef64fca1ba

@n0toose n0toose added the hacktoberfest Contributions meant for DigitalOcean's Hacktoberfest event. label Oct 4, 2021
@vchernin
Copy link
Author

vchernin commented Oct 4, 2021

@n0toose
Copy link
Member

n0toose commented Jan 30, 2022

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design Issues and pull requests concerning the design and overall look and feel of the project. enhancement Idea or request for new feature hacktoberfest Contributions meant for DigitalOcean's Hacktoberfest event.
Projects
None yet
Development

No branches or pull requests

3 participants