From 5f39eea895953d3fa9a331f13e806a7ac3efd7d8 Mon Sep 17 00:00:00 2001
From: sotojn <jsoto@terascope.com>
Date: Wed, 24 Jul 2024 10:08:34 -0700
Subject: [PATCH 1/2] update node versions in matrix

---
 .github/workflows/asset-build-and-publish.yml | 4 ++--
 .github/workflows/asset-test.yml              | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/asset-build-and-publish.yml b/.github/workflows/asset-build-and-publish.yml
index 8867d43..f4db533 100644
--- a/.github/workflows/asset-build-and-publish.yml
+++ b/.github/workflows/asset-build-and-publish.yml
@@ -17,7 +17,7 @@ jobs:
     strategy:
       matrix:
         # NOTE: Hard Coded Node Version array, should match array in test-asset.yml
-        node-version: [18.19.1, 20.11.1, 22.2.0]
+        node-version: [18, 20, 22.4.1]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
@@ -49,7 +49,7 @@ jobs:
       - uses: actions/setup-node@v3
         with:
           # NOTE: Hard Coded Node Version
-          node-version: '18.19.1'
+          node-version: '18'
           registry-url: 'https://registry.npmjs.org'
       - run: yarn setup
       - run: ./scripts/publish.sh
diff --git a/.github/workflows/asset-test.yml b/.github/workflows/asset-test.yml
index 30954a2..4fcd48a 100644
--- a/.github/workflows/asset-test.yml
+++ b/.github/workflows/asset-test.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       matrix:
         # NOTE: Hard Coded Node Version array, should match array in build-and-publish-asset.yml
-        node-version: [18.19.1, 20.11.1, 22.2.0]
+        node-version: [18, 20, 22.4.1]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
@@ -39,7 +39,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           # NOTE: Hard Coded Node Version
-          node-version: '18.19.1'
+          node-version: '18'
       # NOTE: Prevent python 3.12 breaking node-gyp installations in the kafka asset
       # TODO: try default python again in the future 
       - name: Use Python 3.11

From e126e121f298bc2dd0acd43a434dd8931c580070 Mon Sep 17 00:00:00 2001
From: sotojn <jsoto@terascope.com>
Date: Wed, 24 Jul 2024 15:15:39 -0700
Subject: [PATCH 2/2] unpin node 22

---
 .github/workflows/asset-build-and-publish.yml | 2 +-
 .github/workflows/asset-test.yml              | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/asset-build-and-publish.yml b/.github/workflows/asset-build-and-publish.yml
index f4db533..9a534f9 100644
--- a/.github/workflows/asset-build-and-publish.yml
+++ b/.github/workflows/asset-build-and-publish.yml
@@ -17,7 +17,7 @@ jobs:
     strategy:
       matrix:
         # NOTE: Hard Coded Node Version array, should match array in test-asset.yml
-        node-version: [18, 20, 22.4.1]
+        node-version: [18, 20, 22]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}
diff --git a/.github/workflows/asset-test.yml b/.github/workflows/asset-test.yml
index 4fcd48a..2e9be72 100644
--- a/.github/workflows/asset-test.yml
+++ b/.github/workflows/asset-test.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       matrix:
         # NOTE: Hard Coded Node Version array, should match array in build-and-publish-asset.yml
-        node-version: [18, 20, 22.4.1]
+        node-version: [18, 20, 22]
     steps:
       - uses: actions/checkout@v3
       - name: Use Node.js ${{ matrix.node-version }}