Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed bug with cloud logs naming logic #254

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

ocofaigh
Copy link
Member

@ocofaigh ocofaigh commented Feb 6, 2025

Description

The current logic is wrongly naming the cloud logs instance when a prefix is used. I have added the fix that makes it consistent with all other instances we provision in DAs, and aligns the the variable descrption:

"The name of the IBM Cloud Logs instance to create. If a prefix input variable is passed, it is prefixed to the value in the <prefix>-value format."

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Member Author

ocofaigh commented Feb 6, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 14227d9 into main Feb 6, 2025
2 checks passed
@ocofaigh ocofaigh deleted the ocofaigh-patch-1 branch February 6, 2025 12:04
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants