Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getparam: buffer overflow #35

Closed
teuben opened this issue May 28, 2020 · 1 comment
Closed

getparam: buffer overflow #35

teuben opened this issue May 28, 2020 · 1 comment

Comments

@teuben
Copy link
Owner

teuben commented May 28, 2020

Example:
ccdfits model.10.smooth model.10.fitsradecvel=t
*** buffer overflow detected ***: terminated
Aborted (core dumped)

seems the (wrong in this case) keyword is too long

@teuben
Copy link
Owner Author

teuben commented Nov 5, 2022

This was a short MAXKEYLEN temporary buffer that was too short. Made it 64, changed strcpy -> strncpy to protect, but a few traps like this remain in getparam. Marking this is almost done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant