From c83f118d5977cf1e661922bac80cba0821cf3d38 Mon Sep 17 00:00:00 2001 From: Yukai Chou Date: Tue, 19 Dec 2023 03:07:25 +0800 Subject: [PATCH 1/2] ci: bump GeekyEggo/delete-artifact from 2.0.0 to 4 - v4 adds support for `actions/download-artifact@v4` - batch delete artifacts see https://github.com/GeekyEggo/delete-artifact/releases/tag/v4.0.0 --- .github/workflows/cd.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index 091aa4c6d1..f39f4b89bf 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -235,6 +235,7 @@ jobs: release: permissions: + actions: write # for GeekyEggo/delete-artifact to delete artifacts contents: write # for softprops/action-gh-release to create GitHub release name: Release needs: [build-win10, build-linux-release, macosx] # build-linux-win,macosx-qt5 is disabled @@ -263,7 +264,8 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUBTOKEN }} - - name: Delete temp artifact - uses: GeekyEggo/delete-artifact@v2.0.0 + - name: Delete temp artifacts + uses: GeekyEggo/delete-artifact@v4 with: - name: release + name: release-* + token: ${{ secrets.GITHUB_TOKEN }} From c5fe2ee9db943210fcd524afe5c87ef349d5a820 Mon Sep 17 00:00:00 2001 From: Yukai Chou Date: Mon, 25 Dec 2023 06:15:12 +0800 Subject: [PATCH 2/2] ci: drop a duplicate setting to env `GITHUB_TOKEN` --- .github/workflows/cd.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index f39f4b89bf..8002f6fd19 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -261,8 +261,6 @@ jobs: with: prerelease: ${{ contains(github.ref, 'alpha') || contains(github.ref, 'beta') || contains(github.ref, 'rc') }} files: ./* - env: - GITHUB_TOKEN: ${{ secrets.GITHUBTOKEN }} - name: Delete temp artifacts uses: GeekyEggo/delete-artifact@v4